PLEX-3129 EVM LP skip block#23099
Merged
Merged
Conversation
dhaidashenko
force-pushed
the
feature/PLEX-3129-evm-lp-skip-block
branch
from
89dbf19 to
202bba8
Compare
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
dhaidashenko
force-pushed
the
feature/PLEX-3129-evm-lp-skip-block
branch
from
4ad8858 to
b72b75b
Compare
dhaidashenko
force-pushed
the
feature/PLEX-3129-evm-lp-skip-block
branch
from
9587a5a to
585a8f3
Compare
product-security-plaid-production
Bot
requested review from
ilija42,
kalverra and
mchain0
…evm-lp-skip-block # Conflicts: # core/scripts/go.mod # core/scripts/go.sum # deployment/go.mod # deployment/go.sum # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum # system-tests/lib/go.mod # system-tests/lib/go.sum # system-tests/tests/go.mod # system-tests/tests/go.sum
dhaidashenko
force-pushed
the
feature/PLEX-3129-evm-lp-skip-block
branch
from
572cb25 to
083e43a
Compare
patrickhuie19
previously approved these changes
Jul 15, 2026
amit-momin
previously approved these changes
Jul 15, 2026
…ToBlock build chainlink-common was pinned before PLEX-3129 (#2237) added LPSkipToBlock to types.EVMService, so application.go's call to it didn't compile. Bumping chainlink-common to main pulls that in. Bumping chainlink-common also requires chainlink-evm >= the commit that implements LPSkipToBlock on *Relayer (chainlink-evm#501), which in turn drags NethermindEth/juno to a version that requires tablewriter v1, breaking chainlink-ccv's CLI (still on the v0 API) and this repo's own core/cmd table rendering. Bumping chainlink-ccv to main (which already dropped its tablewriter dependency) fixes the former; a replace pinning tablewriter back to v0.0.5 fixes the latter without having to migrate core/cmd to the v1 API.
patrickhuie19
force-pushed
the
feature/PLEX-3129-evm-lp-skip-block
branch
from
8915cff to
7bf655d
Compare
patrickhuie19
previously approved these changes
Jul 15, 2026
… go modules This is a multi-module repo; the previous commit only bumped the root go.mod. The Clean Go Tidy & Generate CI job runs go mod tidy across all 35 go.mod files and failed because core/scripts, deployment, integration-tests, integration-tests/load, system-tests/lib, and system-tests/tests each pin their own (stale) versions of chainlink-common, chainlink-evm, and chainlink-ccv. Applying the same bump plus the tablewriter v0.0.5 replace (core/scripts also imports tablewriter directly) to each.
The "Misc" CI job's plugin version sync check (tools/plugout) compares this manifest's pinned chainlink-evm SHA against go.mod and failed after the chainlink-evm bump in a prior commit. Ran the tool with --update to bring the manifest back in sync.
The chainlink-evm bump (previous commits) pulled in ~3 weeks of unrelated upstream changes, including removal of deprecated legacy testnet chain defaults (Ropsten, Rinkeby, Goerli, Kovan, etc.) from its bundled default configs. Chain ID 42 (Kovan) is used as a plain test fixture chain in this repo and lost its chain-specific defaults (LinkContractAddress, OperatorFactoryAddress) as a result, with a few other fields falling back to new general defaults. - docs/CONFIG.md: regenerated via `make config-docs`. - core/services/chainlink/testdata/config-multi-chain-effective.toml and the identical duplicate under core/web/resolver/testdata: updated chain 42's expected fields to match. TestComputeExecute's failure in the same CI run is an unrelated, pre-existing timing flake (compute spend-value threshold assertion, untouched by this branch) and needs no fix here.
Contributor
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
patrickhuie19
approved these changes
Jul 15, 2026
Unheilbar
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CLI that allows admin to force LP to start processing block from a new checkpoint.
Depends on: